-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39176/31764

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39176/31764/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39176/31764/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39176/31767

• This PR adds an extra 16KB to repository

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• CalibCalorimetry/CastorCalib (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

please test

type bugfix,castor

type bugfix,castor

@tvami I don't think there's castor label

type bugfix,castor

@tvami I don't think there's castor label

@smuzaffar although Castor is decommissioned, the code still exists. I think making the label would be helpful.

type bugfix,castor

@tvami I don't think there's castor label

@smuzaffar although Castor is decommissioned, the code still exists. I think making the label would be helpful.

if it is just for label then I can update https://github.com/cms-sw/cms-bot/blob/master/githublabels.py#L33 to include castor otherwise please suggest a change for CMSSW_L2 at https://github.com/cms-sw/cms-bot/blob/master/categories.py#L141

if it is just for label then I can update

it's just a label, we dont need the L2 category

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-851d57/27058/summary.html
COMMIT: 2f5d80a
CMSSW: CMSSW_12_5_X_2022-08-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39176/27058/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3693084
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3693054
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

+alca

• test pass, failures in MsgL only
• with the caveat that there is more to do in a follow-up PR as described in Run3-gex138 Replace getbylabel using token in CalibCalorimetry/CastorCalib #39176 (review)

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

+1